Skip to content

chore(deps): bump @google/model-viewer from 2.1.1 to 4.0.0 #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(deps): bump @google/model-viewer from 2.1.1 to 4.0.0 #5564

wants to merge 1 commit into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 2, 2024 •
edited by pr-codex bot
Loading

Bumps @google/model-viewer from 2.1.1 to 4.0.0.

Release notes

Sourced from @​google/model-viewer's releases.

v4.0.0

✋Breaking Change

  • Our default tone-mapping has been updated to PBR Neutral, for improved color accuracy. If you have not been specifying tone-mapping, you'll need to either regenerate your poster images or use tone-mapping="aces" to get our legacy behavior. #4886
  • The default min and max camera-orbit have been updated to allow straight top and bottom views. #4916

Bug fixes

  • Fixed variants. #4882
  • Fixed surface hotspot updates. #4867
  • Fixed withCredentials updating. #4892
  • getCameraTarget now returns the instantaneous position, like getCameraOrbit. #4895

Examples

✨ Updated model documentation. #4776 ✨ Fixed material picking example to work in WebXR mode, thanks @​Hamidrzash! #4851

Other notable changes

  • Upgraded to Three.js r169. #4885, #4907
  • We no longer require a meta viewport tag to render at full DPR resolution. #4896
  • Moved the render fidelity comparisons out of this repo to Khronos ownership. #4779

Editor

v3.5.0

Features

🆕 Added localization API for a11y for WCAG compliance, thanks @​cybmiper! #4715 🆕 Added Khronos PBR Neutral tone mapping standard ("neutral") - "commerce" is now an alias for this. #4716, #4760

Bug fixes

  • Fixed USDZ auto-generation when changing baseColorFactor. #4690
  • Fixed progress event reason propagation, thanks @​rsleyland! #4701
  • Fixed build problems related to imports, thanks @​chamby! #4707, #4710
  • Fixed DPR for iframes. #4723
  • Fixed grounded skybox rotation. #4752
  • Fixed USDZ rotation. #4753
  • Fixed toBlob for offscreen elements. #4754
  • Improved performance when model-viewer.js loads before a 3D element is visible, thanks @​Arecsu! #4758

Examples

✨ Added example of a11y localization, thanks @​cybmiper! #4715

Other notable changes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

PR-Codex overview

This PR updates various package versions in the package.json and pnpm-lock.yaml files, including a significant upgrade of @google/model-viewer from 2.1.1 to 4.0.0. It also makes adjustments to dependency versions across multiple packages.

Detailed summary

  • Updated @google/model-viewer from 2.1.1 to 4.0.0.
  • Adjusted versioning for @vercel/functions to include @aws-sdk/[email protected].
  • Enhanced dependency resolution for multiple packages to include @swc/[email protected].
  • Minor version adjustments for various packages in pnpm-lock.yaml.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@dependabot
chore(deps): bump @google/model-viewer from 2.1.1 to 4.0.0
b4d1dbc 
Bumps [@google/model-viewer](https://github.com/google/model-viewer) from 2.1.1 to 4.0.0.
- [Release notes](https://github.com/google/model-viewer/releases)
- [Commits](google/model-viewer@v2.1.1...v4.0.0)

---
updated-dependencies:
- dependency-name: "@google/model-viewer"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 2, 2024
@dependabot dependabot bot requested a review from jnsdls as a code owner December 2, 2024 20:31
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: b4d1dbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🛑 Canceled (Inspect) Dec 2, 2024 8:32pm
thirdweb_playground 🛑 Canceled (Inspect) Dec 2, 2024 8:32pm
thirdweb-www 🛑 Canceled (Inspect) Dec 2, 2024 8:32pm
wallet-ui 🛑 Canceled (Inspect) Dec 2, 2024 8:32pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 20:31 Inactive
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 2, 2024
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 20:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 20:32 Inactive
@jnsdls jnsdls closed this Dec 2, 2024
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 2, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/google/model-viewer-4.0.0 branch December 2, 2024 20:32
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 2, 2024 20:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@jnsdls jnsdls Awaiting requested review from jnsdls

Assignees

No one assigned

Labels

Dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnsdls